Skip to content

ADFA-3597: Layout Editor plugin#38

Open
Daniel-ADFA wants to merge 2 commits into
mainfrom
ADFA3597-plugin
Open

ADFA-3597: Layout Editor plugin#38
Daniel-ADFA wants to merge 2 commits into
mainfrom
ADFA3597-plugin

Conversation

@Daniel-ADFA

@Daniel-ADFA Daniel-ADFA commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator
Screen_recording_20260702_232315.webm

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

A visual drag-and-drop editor for Android XML layouts. Contributes a preview-slot
toolbar action (enabled only when a layout XML file is open and the last sync
succeeded), a full-screen editor with palette, component tree, typed attribute
dialogs, and a resource manager, and long-press documentation on every control.
Includes README.md and layout-editor-documentation.html.
@Daniel-ADFA Daniel-ADFA requested a review from a team July 2, 2026 22:24

@jatezzz jatezzz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just make sure all user-facing strings are in strings.xml.

Address review feedback from @jatezzz: extract remaining hardcoded
user-facing strings across the Layout Editor plugin into string
resources (following the existing ColorResourceAdapter convention),
reusing existing entries where available.

- StringResourceAdapter: remove/edit dialog titles + confirm message
- StringFragment / ProjectListAdapter: dialog titles
- AttributeDialog: default Cancel/Save button labels
- Color/String/Size/Dimension/NumberDialog: hints and error messages
@Daniel-ADFA Daniel-ADFA requested a review from jatezzz July 3, 2026 13:33

@jatezzz jatezzz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants