ADFA-3597: Layout Editor plugin#38
Open
Daniel-ADFA wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
62a3c8f to
54bc519
Compare
A visual drag-and-drop editor for Android XML layouts. Contributes a preview-slot toolbar action (enabled only when a layout XML file is open and the last sync succeeded), a full-screen editor with palette, component tree, typed attribute dialogs, and a resource manager, and long-press documentation on every control. Includes README.md and layout-editor-documentation.html.
54bc519 to
651b10e
Compare
jatezzz
requested changes
Jul 3, 2026
jatezzz
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Just make sure all user-facing strings are in strings.xml.
Address review feedback from @jatezzz: extract remaining hardcoded user-facing strings across the Layout Editor plugin into string resources (following the existing ColorResourceAdapter convention), reusing existing entries where available. - StringResourceAdapter: remove/edit dialog titles + confirm message - StringFragment / ProjectListAdapter: dialog titles - AttributeDialog: default Cancel/Save button labels - Color/String/Size/Dimension/NumberDialog: hints and error messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen_recording_20260702_232315.webm